-
Notifications
You must be signed in to change notification settings - Fork 795
[UR][L0] Implement support for device to device copy #19106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: sycl
Are you sure you want to change the base?
Conversation
fe46057 to
881888b
Compare
881888b to
046bcb4
Compare
Bindless Image: pitched usm image to pitched usm image copy Signed-off-by: Zhang, Winston <[email protected]>
Bindless Image: pitched usm image to pitched usm image copy Signed-off-by: Zhang, Winston <[email protected]>
31cf4f9 to
f264ec6
Compare
27e48c2 to
1e85a56
Compare
|
sycl/test-e2e/bindless_images/copies/device_to_device_copy.cpp is still marked as only supported by cuda Alternatively one could add corresponding tests that are more unit-like for this feature, as described here: #16977 (comment) Fundamentally, it is not clear what user use case this PR fixes. I can see that it is challenging, since the L0 spec seems to diverge from the bindless-images spec in that it always appears to use a ze_image, rather than provided interfaces that take bare pointers. And hence you have having to do some awkward massaging from one interface to the other, that is challenging to review from a correctness point of view, particularly with the aforementioned lack of tests. The bindless-images interfaces for using bare pointer images were designed with industry standards in mind, that reflect the real use cases of image applications. It may be worthwhile to reconsider the level zero bindless-images specification if it does not allow efficient usage of target use cases of image applications. Practically, the way to avoid this, is ideally to have some end-to-end tests that reflect in as minimal way as possible the requirements of the feature for end-users. I think that you will save lots of time overall, if you first consider such a test requirement, and then do whatever is required within the implementation following that, taking into account the possible need to adjust the l0 bindless-images spec if it does not meet industry requirements. "Impatience is the cardinal sin from which all others spawn" - Franz Kafka |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend either enabling existing tests on L0 that utilize this functionality, or adding new appropriate tests that encapsulate end-user requirements, and are more specific unit-tests for the device-to-device pitched copy feature. The relevant existing tests are described here: #19106 (comment)
Bindless Image: pitched usm image to pitched usm image copy